Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf: update external javadoc link (v1.51.x backport) #9891

Merged
merged 1 commit into from
Feb 13, 2023
Merged

protobuf: update external javadoc link (v1.51.x backport) #9891

merged 1 commit into from
Feb 13, 2023

Conversation

temawi
Copy link
Contributor

@temawi temawi commented Feb 13, 2023

No description provided.

@temawi temawi requested a review from sergiitk February 13, 2023 19:06
sergiitk
sergiitk reviewed Feb 13, 2023
View reviewed changes
protobuf/build.gradle
@@ -30,5 +30,5 @@ dependencies {
}

tasks.named("javadoc").configure {
options.links 'https://developers.google.com/protocol-buffers/docs/reference/java/'
options.links 'https://protobuf.dev/reference/java/api-docs/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting Not found

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did perhaps mean https://protobuf.dev/reference/java/?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that is a prefix added to outgoing links so it would not by itself point to anything. This change already fixed the build on master so it should be correct.

sergiitk
sergiitk approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the right link, but feel free to merge if you're know otherwise.

@temawi temawi merged commit 0be514f into grpc:v1.51.x Feb 13, 2023
@temawi temawi deleted the backport-protobuf-javadoc-link-1.51 branch February 13, 2023 19:34
temawi added a commit to temawi/grpc-java that referenced this pull request Feb 13, 2023
@temawi
protobuf: update external javadoc link (grpc#9890) (grpc#9891)
a4c43ee
temawi added a commit that referenced this pull request Feb 13, 2023
@temawi
xds: Support localities in multiple priorities (v1.51.x backport) (#9888
63ace74 
)

* xds: Support localities in multiple priorities (#9683)

Additional logic to support for the same locality appearing under
multiple priorities.

* protobuf: update external javadoc link (#9890) (#9891)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sergiitk sergiitk sergiitk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@temawi @sergiitk