Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on Old Protobufjs #103

Closed
Harmonickey opened this issue Nov 27, 2017 · 6 comments
Closed

Dependency on Old Protobufjs #103

Harmonickey opened this issue Nov 27, 2017 · 6 comments

Comments

@Harmonickey
Copy link

Wasn't there a fix to use the new protobufjs 6 version?

grpc/grpc#8991

However, when I pull down the latest grpc 1.7.2 version, it is still dependent on 5.0.0. It would be useful to have version 6 in there so that I can use loading property and proto verification especially with messages that use the virtual oneof parameters.

{
  "name": "grpc",
  "version": "1.7.2",
  "author": "Google Inc.",
  "description": "gRPC Library for Node",
  "homepage": "https://grpc.io/",
  "repository": {
    "type": "git",
    "url": "https://github.com/grpc/grpc-node.git"
  },
  "bugs": "https://github.com/grpc/grpc-node/issues",
  "contributors": [
    {
      "name": "Michael Lumish",
      "email": "mlumish@google.com"
    }
  ],
  "directories": {
    "lib": "src"
  },
  "scripts": {
    "build": "./node_modules/.bin/node-pre-gyp build",
    "electron-build": "./node_modules/.bin/node-pre-gyp configure build --runtime=electron --disturl=https://atom.io/download/atom-shell",
    "coverage": "./node_modules/.bin/istanbul cover ./node_modules/.bin/_mocha test",
    "install": "./node_modules/.bin/node-pre-gyp install --fallback-to-build --library=static_library"
  },
  "bundledDependencies": [
    "node-pre-gyp"
  ],
  "dependencies": {
    "arguejs": "^0.2.3",
    "lodash": "^4.15.0",
    "nan": "^2.8.0",
    "node-pre-gyp": "^0.6.39",
    "protobufjs": "^5.0.0"
  },

I am not doing anything special other than just
npm install grpc

@murgatroid99
Copy link
Member

That change that switched to Protobuf.js 6 was almost immediately reverted because it turned out to be a breaking change. We are currently working on a better way to do that.

@Harmonickey
Copy link
Author

Ah, understood. Thank you.

@shinzui
Copy link

shinzui commented Apr 5, 2018

Any updates on upgrading protobuf.js to the latest version?

@murgatroid99
Copy link
Member

We are very close to publishing a new separate utility package for using Protobuf.js 6 with gRPC.

@murgatroid99
Copy link
Member

We have now published @grpc/proto-loader which depends on the newest version of Protobuf.js. Please try it out and tell us about any issues you experience.

@Harmonickey
Copy link
Author

So far looking good. I think it's fair to close this ticket.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants