Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in typings of KeyCertPair #170

Closed
dhcode opened this issue Feb 3, 2018 · 1 comment
Closed

Error in typings of KeyCertPair #170

dhcode opened this issue Feb 3, 2018 · 1 comment
Assignees

Comments

@dhcode
Copy link

dhcode commented Feb 3, 2018

I just started experimenting with GRPC using node.js with TypeScript.

Typing errors appeared for KeyCertPair:

* @property {Buffer} privateKey The server's private key

Instead of privateKey it should be private_key.
Instead of certChain it should be cert_chain.

Then it works.

@murgatroid99
Copy link
Member

Thank you for reporting this. The fix should be in the next release.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants