Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance loss since @grpc/grpc-js version 1.6.8 #2231

Closed
antonstefer opened this issue Sep 20, 2022 · 2 comments
Closed

Performance loss since @grpc/grpc-js version 1.6.8 #2231

antonstefer opened this issue Sep 20, 2022 · 2 comments
Assignees

Comments

@antonstefer
Copy link

Problem description

I use @google-cloud/bigtable which depends on @grpc/grpc-js through grpc-gcp and google-gax (maybe in more ways). When updating from 1.6.7 to 1.6.8 or any version above that, bigtable calls (especially ReadRows queries) get significantly slower (about 100% on average).

Reproduction steps

Use bigtable with both of the above versions and perform ReadRows queries on tables.

Environment

  • Google Cloud, Kubernetes Cluster, Container-Optimized OS from Google
  • node:16-alpine docker image
  • @grpc/grpc-js@1.6.8 or above
  • google managed bigtable instance

Additional context

As this is only a performance issue we do not see any error logs. We have created trace analysis reports using the google cloud platform which show the difference in execution time.

before:
before

after:
after

@murgatroid99
Copy link
Member

I published grpc-js version 1.7.1 with a change that will hopefully improve this situation. Please try it out.

@antonstefer
Copy link
Author

It works, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants