TypeError: Cannot read properties of undefined (reading 'state')

[Fonger]

Problem description

After we upgrade @grpc/grpc-js from 1.7.3 to 1.8.7, we start to see server crash frequently with this error:

TypeError: Cannot read properties of undefined (reading 'state')
    at RetryingCall.sendMessageWithContext (/workspace/node_modules/@grpc/grpc-js/build/src/retrying-call.js:542:22)
    at /workspace/node_modules/@grpc/grpc-js/build/src/resolving-call.js:106:19
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

This map to this line 597 call.state === 'ACTIVE'

grpc-node/packages/grpc-js/src/retrying-call.ts

Lines 593 to 598 in d209a34

	} else {
	this.commitCallWithMostMessages();
	const call = this.underlyingCalls[this.committedCallIndex!];
	bufferEntry.callback = context.callback;
	if (call.state === 'ACTIVE' && call.nextMessageToSend === messageIndex) {
	call.call.sendMessageWithContext({

Reproduction steps

Sorry I can't give a precise step to reproduce for now, however maybe it's possible to find the issue by code review?

I suspect it's because this.commitedCallIndex is -1 because this.underlyingCalls is an empty array.

grpc-node/packages/grpc-js/src/retrying-call.ts

Lines 267 to 275 in d209a34

	let mostMessages = -1;
	let callWithMostMessages = -1;
	for (const [index, childCall] of this.underlyingCalls.entries()) {
	if (childCall.nextMessageToSend > mostMessages) {
	mostMessages = childCall.nextMessageToSend;
	callWithMostMessages = index;
	}
	}
	this.commitCall(callWithMostMessages);

Or committedCallIndex is null because this.state is COMMITED or COMPLETED but we force nullish! here.

grpc-node/packages/grpc-js/src/retrying-call.ts

Line 595 in d209a34

const call = this.underlyingCalls[this.committedCallIndex!];

Or one of element of underlyingCalls maybe undefined so we should use optional chaining like this one here: (I think this one is unlikely)

grpc-node/packages/grpc-js/src/retrying-call.ts

Line 624 in d209a34

if (call?.state === 'ACTIVE' && call.nextMessageToSend === halfCloseIndex) {

The only dependency we use @grpc/grpc-js is opentelemetry @opentelemetry/exporter-trace-otlp-grpc 0.34.0.

Environment

• OS name, version and architecture: Alpine Linux v3.17
• Node version: v18.14.0
• Node installation method: docker node:18-alpine
• If applicable, compiler version:
• Package name and version: @grpc/grpc-js@1.8.7

Additional context

[murgatroid99]

I think I fixed the issue in version 1.8.8. Please update and try it out.

[Fonger]

I think I fixed the issue in version 1.8.8. Please update and try it out.

Thanks! I can confirm this is fixed in 1.8.8.