Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extension point for a channel creation factory #386

Closed
3 tasks
murgatroid99 opened this issue Jun 5, 2018 · 0 comments · Fixed by #446
Closed
3 tasks

Add extension point for a channel creation factory #386

murgatroid99 opened this issue Jun 5, 2018 · 0 comments · Fixed by #446
Assignees
@murgatroid99

Comments

@murgatroid99
Copy link
Member

This will require us to do the following:

  • Modify the C++ wrapping code to create Call objects using a method on Channel instead of a Call constructor.
  • Expose the Channel class in the library API. Note that this will also impact the grpc-js library, which needs to expose the same API
  • Add a channelFactoryOverride option to the Client constructor.
@murgatroid99 murgatroid99 self-assigned this Jun 5, 2018
@murgatroid99 murgatroid99 mentioned this issue Jul 19, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@murgatroid99 murgatroid99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Channel class and Client channel override options to public API murgatroid99/grpc-node
1 participant
@murgatroid99