Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grpc generated pb_d.ts. Incorrect import #336

Closed
weilip1803 opened this issue Oct 24, 2018 · 2 comments
Closed

Grpc generated pb_d.ts. Incorrect import #336

weilip1803 opened this issue Oct 24, 2018 · 2 comments

Comments

@weilip1803
Copy link

protoc -I=./platform/ ft_pform/healthcheck.proto --js_out=import_style=commonjs:./generated_proto --grpc-web_out=import_style=commonjs+dts,mode=grpcwebtext:./generated_proto

The following command will cause the healthcheck_grpc_web_pb.d.ts file to import the proto files from
./ft_pform/healthcheck_pb instead of ./healthcheck_pb which is the correct one.

The rest of the js files are generated correctly.

@stanley-cheung
Copy link
Collaborator

Acknowledged. Looks like it's yet another edge case we haven't handled: with the combination of specifying -I= flag, with an input proto in a subdirectory, and with specifying an output directory at the plugin level. At first glance I don't even know what the correct behavior should be. Will look into that.

@weilip1803
Copy link
Author

This issue is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants