-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC Hello World Guide is out of date for Windows and Mac users #436
Comments
Thank you so much. I was unable to get this started after your suggestion initially because I didn't kill all the docker processes/container after changes. |
I need another suggestion. |
Did you build docker container and run it properly? Caveats in the hello world tutorial - it's quite outdated in the docker part - |
I build docker container from PowerShell with command My Dockerfile:
envoy.yaml:
I run docker with command:
Result: |
- created new README off old addenda file - edited envoy.yaml and modified README as per grpc/grpc-web#436
I have added all the changes recommended to get the hello world example to run into this repo https://github.com/oinke/gprc-hello The terminal still shows: Running on macOS Mojave 10.14.2 with Docker version 18.09.2, build 6247962 |
- Notes from issue 436 (grpc#436)
Notes added to doc. |
@stanley-cheung shall we open this again? the envoy.yaml file is using a property (hosts) that is deprecated https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/cds.proto#envoy-api-file-envoy-api-v2-cds-proto |
@gsantopaolo yes it should be opened. It is not still working on the latest Mac. |
is this command still working? windows docker docker run -d -v "$(pwd)"/envoy.yaml:/etc/envoy/envoy.yaml:ro i tried as well docker run -d -v ./envoy.yaml:/etc/envoy/envoy.yaml:ro First command doesnt execute |
For reference i'm using Windows 10 Pro but do all my development stuff using WSL2 So if you're using
make sure you also update your connection
this can stay the same for both
your cluster as follows
you'll notice the only difference is i'm using To ensure that your connection is working, navigate to http://localhost:9901/clusters and ensure that your service is not failing to receive connections
I'm more than happy to update the readme with some new examples. cheers |
The README.md doc for the Hello World guide is out of date for Windows and Mac users. Specifically, the
envoy.yaml
file should be updated with a clarification for Mac and Windows users that instead of usingaddress: localhost
, they should useaddress: host.docker.internal
under theclusters
field due to idiosyncrasies with how the docker VM is configured on these machines.Furthermore, the command to launch the Envoy proxy under these OSes is slightly different (
--network=host
should be removed) so the command should be:The text was updated successfully, but these errors were encountered: