Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement client to server streaming #815

Closed
ydesgagn opened this issue May 19, 2020 · 10 comments
Closed

Implement client to server streaming #815

ydesgagn opened this issue May 19, 2020 · 10 comments

Comments

@ydesgagn
Copy link

Hi,

I know client to server streaming is not supported but the other way is according to the readme.

Do you have any plan to add it? It would be really helpful for us as we have to file upload endpoint using streaming.

service FileService {
    // Upload a user submitted file
    rpc UploadFile (stream UploadFileRequest) returns (UploadFileResponse);
}

Thanks

@ydesgagn
Copy link
Author

I would be willing to allocate 1-2 engineers on this to create a PR. Any guidelines we should follow so the PR can be accepted smoothly?

@wenbozhu
Copy link
Member

What Web API do you plan to use to implement the client side support?

Fetch/stream doesn't yet support streamed upload. We will be doing some origin trial in chrome to decide if streamed upload will work reliably on Internet.

@mrmeku
Copy link

mrmeku commented Sep 29, 2020

@wenbozhu As a strawman for a potential solution, would using a websocket between client and server be sufficient to implement this feature? To me that seems like the obvious solution, but if it has drawbacks I think it would be good to document them here to inform other potential solutions

@wenbozhu
Copy link
Member

wenbozhu commented Oct 9, 2020

@mrmeku I added a section on the streaming-road-map doc.

===

Chrome origin trial for fetch/upload is still in progress. Will update this thread with the results.

@dunkymole
Copy link

dunkymole commented Feb 18, 2021

Hey @wenbozhu. The trials seems to run to Jul 14, 2021, is this the earliest we can expect an update?

@wenbozhu
Copy link
Member

We ran into some bugs (crashes) in chrome and the fix is out and next OT is in progress. Will provide an update soon.

@dunkymole
Copy link

dunkymole commented Apr 21, 2021

Hi. Any update? :-)

@wenbozhu
Copy link
Member

The chrome origin trial is still on-going, which revealed a few bugs and caused a few wide issues for google services (due to the code that enables Origin Trial).

borissmidt pushed a commit to borissmidt/grpc-web that referenced this issue Feb 16, 2022
@Blackclaws
Copy link

Would be interesting to know what the plan for streaming support is going forward. The roadmap docs are 2 years old by this point and there doesn't seem to be a lot of work in these areas.

@sampajano
Copy link
Collaborator

Please refer to #1205.
(Closing this issue since it's duplicate)

I will provide a roadmap update soon! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants