Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error type with RpcError & internal code sync #1139

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

sampajano
Copy link
Collaborator

@sampajano sampajano commented Sep 22, 2021

Summary

  • Internal code sync (up to Aug 4, 2021 for now..) & relevant improvements. :)
  • Updated Closure dependency to 20210808.0.0 (necessary dependency)

Main code changes:

  • Improving error typing to use type RpcError in favor of untyped Error (Thanks @TomiBelan! 😃)
    • Also updated StatusCode to be a enum (not full enum support (e.g. RpcError[RpcError.OK] === 'OK') is there but general === comparison should work)
  • Removed AbstractClientBase.MethodInfo

Other changes:

  • Unifying error behavior in TS and JS echo examples
  • Improved jsunit test runner to throw error when no unit test was found

TODO:

@sampajano sampajano marked this pull request as ready for review September 22, 2021 22:56
stanley-cheung
stanley-cheung previously approved these changes Sep 22, 2021
Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Finally we are able to do the sync!

Up to Aug 4, 2021 for now.. :)

- Also updated Closure dependency to `20210808.0.0` (necessary for tests to pass)
@sampajano sampajano merged commit 627e337 into grpc:master Sep 22, 2021
@sampajano sampajano deleted the 1-code-sync branch September 22, 2021 23:54
@sampajano sampajano changed the title Internal code sync Improving error types and internal code sync Oct 13, 2021
@sampajano sampajano changed the title Improving error types and internal code sync Introducing RpcError and internal code sync Oct 13, 2021
@sampajano sampajano changed the title Introducing RpcError and internal code sync Improve error type with RpcError and internal code sync Oct 13, 2021
@sampajano sampajano changed the title Improve error type with RpcError and internal code sync Improve error type with RpcError & internal code sync Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants