Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RpcError.code typing & internal code sync #1140

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Improve RpcError.code typing & internal code sync #1140

merged 1 commit into from
Sep 28, 2021

Conversation

sampajano
Copy link
Collaborator

@sampajano sampajano commented Sep 23, 2021 •
edited
Loading

Notable changes:

  • Improve typing of RpcError.code from number -> StatusCode (Thanks @richieforeman! 馃槂)
  • Returning StatusCode.INTERNAL during deserialization errors (per spec)
  • Moved protoc generator to its own package

stanley-cheung
stanley-cheung approved these changes Sep 28, 2021
View reviewed changes
Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@sampajano sampajano merged commit f1fe574 into grpc:master Sep 28, 2021
@sampajano sampajano deleted the 1-code-sync branch September 28, 2021 17:48
@sampajano sampajano changed the title Internal code sync Improving RpcError.code typing and internal code sync Oct 13, 2021
@sampajano sampajano changed the title Improving RpcError.code typing and internal code sync Improving RpcError.code typing & internal code sync Oct 13, 2021
@sampajano sampajano changed the title Improving RpcError.code typing & internal code sync Improving RpcError.code typing & internal code sync Oct 13, 2021
@sampajano sampajano changed the title Improving RpcError.code typing & internal code sync Improve RpcError.code typing & internal code sync Oct 13, 2021
@chenrui333 chenrui333 mentioned this pull request Oct 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

Assignees
No one assigned
Labels
release notes: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sampajano @stanley-cheung