Expose MethodDescriptor's public methods #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sampajano
reviewed
Nov 8, 2021
There was a problem hiding this comment.
Thanks for the contrib! :)
This in principle is fine with me. I'm a bit surprised that these aren't exported already given it's already in the TS interface.
@stanley-cheung would probably have more context here so i'll wait for his review :)
(BTW you need to finish the CLA process for this PR to be merge-able :))
stanley-cheung
approved these changes
Nov 8, 2021
sampajano
approved these changes
Nov 17, 2021
sampajano
added
kokoro:run
kokoro:force-run
and removed
kokoro:run
kokoro:force-run
labels
|
Hi @tomferreira.. Unfortunately i have to rollback this PR because after merging this change it's causing some non-trivial code size increases for some internal Google products.. Apologize for the inconveniences.. 😅 I think maybe there are some ways to expose these APIs ONLY for Github. But I'm not totally sure yet. Ideas are welcome too.. 😃 |
sampajano
added a commit
that referenced
this pull request
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the public methods of the MethodDescriptor class to be used in a mock implementation proposal of interceptor.