-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update envoy version to 1.22 (with config updates) #1222
Conversation
|
@tomk9 Thanks so much for the change!! Interestingly, didn't find anything mentioning about a "breaking change" in Envoy 1.22 change log.. But it did mention a few things about "typed configuration" and "filter".. :) https://www.envoyproxy.io/docs/envoy/latest/version_history/v1.22.0 Could it be a bug on Envoy side? ============================ Aha found this PR: envoyproxy/envoy#20397 It's said to be "strongly recommended" but not required.. but i guess in that case we should adopt it anyways.. 😄 |
- name: envoy.filters.http.grpc_web | ||
- name: envoy.filters.http.cors | ||
- name: envoy.filters.http.router | ||
- name: envoy.filters.http.grpc_web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious - does the name still matter now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked. Looks like the name doesn't matter anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i see! Good to know.. Thanks for checking! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for helping here! The change looks awesome!! Much appreciated! 😃
- name: envoy.filters.http.router | ||
- name: envoy.filters.http.grpc_web | ||
typed_config: | ||
"@type": type.googleapis.com/envoy.extensions.filters.http.grpc_web.v3.GrpcWeb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious - how did you compose this string? :)
i can see extensions.filters.http.grpc_web.v3.GrpcWeb
being mentioned on Envoy doc, but what about the type.googleapis.com
(maybe it's by convention or "just works"😂) ? 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha ok! Thanks for explaining! :)
http_filters: | ||
- name: envoy.grpc_web | ||
- name: envoy.router | ||
- name: listener_0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing the tutorial up-to-date and fixing the formatting too! 😃
#1220