Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface underlying XHR errors better #206

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

stanley-cheung
Copy link
Collaborator

@stanley-cheung stanley-cheung commented Jul 13, 2018

Fixes #201

This PR attempts to surface errors better for the case where

  • The proxy goes away or there are network problems
  • Proxy runs fine, but the backend gRPC server goes away

@stanley-cheung stanley-cheung merged commit 6357fa7 into grpc:master Jul 16, 2018
@stanley-cheung stanley-cheung deleted the surface-stream-error branch July 25, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communication error handling
1 participant