Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to codegen plugin #249

Merged
merged 2 commits into from
Aug 20, 2018

Conversation

stanley-cheung
Copy link
Collaborator

Fixes #244
Fixes #245

This PR introduces the following changes:

cc @rwlincoln

@rwlincoln
Copy link

Note that the gRPC Node JS plug-in generates files with names of the form <proto>_grpc_pb.js.

I might not have been building the correct branch, but I think the out= configuration option is still required and should be made optional.

@stanley-cheung
Copy link
Collaborator Author

out= should no longer be required. When not specified, filename should be in the form of <proto>_grpc_pb.js

@rwlincoln
Copy link

I checked out the correct commit and the out= option is indeed no longer required. The require paths account for the directory hierarchy and it is possible to pass multiple .protos into a single protoc call.

Can the generated files be named <proto>_grpcweb_pb.js or something similar? This would prevent files generated by the gRPC Node.js plug-in from being overwritten.

@stanley-cheung
Copy link
Collaborator Author

Sounds good. Generated files are now named <proto>_grpc_web_pb.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants