Promise function should use ES5 functions rather than fat arrows (IE browser support) #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stanley-cheung Keen to get your thoughts on this one; You back from the holidays? |
|
There are other places we are spitting out arrow functions but those are for TypeScript output so we should be fine there. This is the only place for the normal JS output. |
|
Thanks @stanley-cheung |
loyalpartner
pushed a commit
to loyalpartner/grpc-web
that referenced
this pull request
Sep 4, 2020
…oding (grpc#427) * Set Content-Length header in NodeHTTPTransport to disable chunked encoding * Only disable chunked http encoding if we are not using streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow functions are not compatible with IE11, this fix allows the generated JS to be used directly in the browser without going through a seperate transpiler (Babel)