Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type error in serverStreaming method #429

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Fix type error in serverStreaming method #429

merged 1 commit into from
Jan 7, 2019

Conversation

johanbrandhorst
Copy link
Collaborator

Fixes #416

@johanbrandhorst
Copy link
Collaborator Author

Without this fix my grpc-web-compatibility-tests are currently broken. This seems to have broken in the last 30 days as well since it was working when I was last testing this! @stanley-cheung @wenbozhu.

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@stanley-cheung stanley-cheung merged commit 7852f2a into grpc:master Jan 7, 2019
@johanbrandhorst johanbrandhorst deleted the patch-1 branch February 8, 2019 21:46
loyalpartner pushed a commit to loyalpartner/grpc-web that referenced this pull request Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime library typescript definition type error
3 participants