Attempt to fix flakiness of 'bazel test' #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks like this works, thanks @Yannic!
I also tried the export OPENSSL_CONF=... fix before and it didn't work. Didn't realize it has to be fixed on the bazel side. Our script seems to be no longer flaky.
Looks like we can remove .bazelrc.
|
Yeah, Bazel is rather picky which parts of the environment are available in tests (If that's good or bad is left as an exercise to the reader). Thanks for your review! |
stanley-cheung
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of the failures might have been fixed in bazelbuild/rules_closure#337.