Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make client args credentials and options optional #512

Merged
merged 3 commits into from
Mar 26, 2019
Merged

Make client args credentials and options optional #512

merged 3 commits into from
Mar 26, 2019

Commits on Mar 22, 2019

  1. Made constructor arguments credentials and options optional 

    Currently the TypeScript generated clients require that `null` be passed to `credentials` and `options` if they're not being used.  It's easier to simply make those arguments optional.  I've left the `null` portion of the type though to maintain backwards compatibility.
    @jonahbron
    jonahbron committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    0090088 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into patch-1

    @jonahbron
    jonahbron committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    3fbc485 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. Merge branch 'master' into patch-1

    @jonahbron
    jonahbron committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    521d267 View commit details
    Browse the repository at this point in the history