Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use explicit envoy release tag #822

Merged
merged 2 commits into from
May 29, 2020
Merged

use explicit envoy release tag #822

merged 2 commits into from
May 29, 2020

Conversation

xsbchen
Copy link
Contributor

@xsbchen xsbchen commented May 27, 2020 •
edited
Loading

fix tag latest not found

Error response from daemon: manifest for envoyproxy/envoy:latest not found: manifest unknown: manifest unknown

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 27, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

stanley-cheung
stanley-cheung approved these changes May 29, 2020
View reviewed changes
Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

This was previously fixed in #787, but we always forgot the helloworld example.

@stanley-cheung stanley-cheung merged commit c963bcf into grpc:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

Assignees
No one assigned
Labels
release notes: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xsbchen @stanley-cheung @grpc-kokoro