Allow multiple .on() callbacks and fix issue with non-OK status #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanley-cheung
force-pushed
the
unary-non-ok-response
branch
from
0063dd9
to
35e8033
Compare
stanley-cheung
changed the title
stanley-cheung
changed the title
This was referenced Jun 23, 2020
This was referenced Jun 27, 2020
borissmidt
pushed a commit
to borissmidt/grpc-web
that referenced
this pull request
Feb 16, 2022
* Replace prototool with buf * Remove dep tooling references * Update protoc and buf versions * Add CI test to ensure files are consistently generated * Update Go version to 1.16 * Remove dependencies added by tool installs in CI * Update module file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #632
Fixes #292
This fixes the issue where calling
.on(<event>, callback)to set a callback should have added the callback to listen to<event>, instead of overriding the existing one. This PR also adds a.removeListener(<event>, callback)method to allow removing a callback.Fixed #786
This fixes the issue where, in unary calls, we should not have sent the data/response back up, if the rpc ended with a non-OK grpc status. See the linked comment from #786 for more details.
This PR also added tests for all the above scenarios.