Add missing types definitions #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanley-cheung
force-pushed
the
intereceptor-ts
branch
from
42872c0
to
d6d2b6e
Compare
stanley-cheung
force-pushed
the
intereceptor-ts
branch
2 times, most recently
from
71e4840
to
912f956
Compare
stanley-cheung
force-pushed
the
intereceptor-ts
branch
from
912f956
to
cc14050
Compare
willsalz
reviewed
Jul 10, 2020
packages/grpc-web/index.d.ts
Outdated
| invoker: (request: Request<Req, Resp>) => | ||
| ClientReadableStream<Resp>): ClientReadableStream<Resp>; | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks for putting this up! I was wondering if you could also add UnaryInterceptor while you're at it?
From: https://github.com/grpc/grpc-web/blob/master/javascript/net/grpc/web/interceptor.js#L47
Suggested change
| export interface UnaryInterceptor<Req, Resp> { | |
| intercept(request: Request<Req, Resp>, | |
| invoker: (request: Request<Req, Resp>) => | |
| Promise<UnaryResponse<Req, Resp>>): Promise<UnaryResponse<Req, Resp>>; | |
| } | |
There was a problem hiding this comment.
Yes literally working on that part as we speak :)
There was a problem hiding this comment.
@willsalz Added the UnaryInterceptor interface typings to the PR. Still WIP. Hopefully should land soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #848: Fixed a bug where we can't pass the interceptors into the client constructor because of a type mismatch.
Fixes #868: Added
MethodDescriptorto the exported types. Replace the deprecatedMethodInfowithMethodDescriptor.Fixes #877: Fixed issue where
UnaryResponsesymbols are being optimized away.And in general added some missing classes to the exported types as well.
Added tests for both callback-based
StreamInterceptorand promise-basedUnaryInterceptor. And now executetscwith--strict.