Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Protobuf .d.ts typings for .proto files without package #941

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Aug 28, 2020

Fixes #939

@Yannic
Copy link
Contributor Author

Yannic commented Aug 28, 2020

/cc @uwemaurer

@stanley-cheung
Copy link
Collaborator

@uwemaurer Thanks for the report.
@Yannic Thanks for the fix.

I was wondering whether we can add some tests for this.

There were some tests involving stuff with no proto package before. See this test proto, and this test for trying to execute these relevant code path in the codegen plugin.

If this has to do with Dts generation and we need to test whether some generated code survives the tsc compilation, we have some proto like this, such that we have tests like this first to run the plugin to generate the generated code (which would exercise the code changed in for example this PR), and then run tsc on the generated code to make sure things are compiled properly.

@Yannic
Copy link
Contributor Author

Yannic commented Aug 30, 2020

@stanley-cheung done! ptal, thanks.

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants