Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go quick start updates: fetch specific version of grpc-go repo, update protoc-gen-go URL #437

Closed
2 tasks done
chalin opened this issue Oct 6, 2020 · 0 comments · Fixed by #504
Closed
2 tasks done
Assignees
Labels
Projects

Comments

@chalin
Copy link
Collaborator

chalin commented Oct 6, 2020


    ```sh
-   $ git clone -b {{< param grpc_go_release_tag >}} https://github.com/grpc/grpc-go
+   $ git clone https://github.com/grpc/grpc-go
    ```
  [Basics tutorial]: ../basics/
- [download]: https://github.com/grpc/grpc-go/archive/{{< param grpc_go_release_tag >}}.zip
+ [download]: https://github.com/grpc/grpc-go/archive/master.zip
  [Getting Started]: https://golang.org/doc/install
@chalin chalin self-assigned this Oct 6, 2020
@chalin chalin changed the title Go quick start: reinstate use of a specific grpc-go repo version Go quick start updates: fetch specific version of grpc-go repo, update protoc-gen-go URL Oct 6, 2020
chalin added a commit that referenced this issue Oct 22, 2020
chalin added a commit that referenced this issue Oct 22, 2020
Contributes to #437. I've done the first part of the Quick start to confirm that it works.

Context: grpc/grpc-go#3932 (comment)
@chalin chalin added this to To do in 20Q4 via automation Oct 27, 2020
chalin added a commit that referenced this issue Nov 6, 2020
Closes #437. Updates made to both the Quick start and the Basics tutorial pages.
20Q4 automation moved this from To do to Done Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
20Q4
Done
Development

Successfully merging a pull request may close this issue.

1 participant