Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add performance best practices guide #790

Merged
merged 6 commits into from
Jul 9, 2021
Merged

Add performance best practices guide #790

merged 6 commits into from
Jul 9, 2021

Conversation

ananda1066
Copy link
Contributor

Ported performance best practices guide from prod to open-source per @jtattermusch's request.

@ananda1066 ananda1066 marked this pull request as ready for review May 25, 2021 21:37
@srini100
Copy link
Contributor

Thanks for this PR! Added a few reviewers for different languages.

markdroth
markdroth suggested changes May 25, 2021
View reviewed changes
content/en/docs/guides/performance.md Outdated Show resolved Hide resolved
content/en/docs/guides/performance.md Outdated Show resolved Hide resolved
vjpai
vjpai approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@vjpai vjpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already reviewed internally and have only minor comments at this point.

content/en/docs/guides/performance.md Outdated Show resolved Hide resolved
content/en/docs/guides/performance.md Outdated Show resolved Hide resolved
ejona86
ejona86 reviewed May 26, 2021
View reviewed changes
content/en/docs/guides/performance.md Outdated Show resolved Hide resolved
content/en/docs/guides/performance.md Outdated Show resolved Hide resolved
content/en/docs/guides/performance.md Outdated Show resolved Hide resolved
ananda1066
ananda1066 commented May 27, 2021
View reviewed changes
Copy link
Contributor Author

@ananda1066 ananda1066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed the comments - PTAL and follow up where needed.

jtattermusch
jtattermusch approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I'm happy with the contents as long as language owners are happy with the corresponding sections.

@dfawley
Copy link
Member

dfawley commented Jun 30, 2021

What is this PR waiting for? Approval from @ejona86 and @markdroth ?

markdroth
markdroth reviewed Jun 30, 2021
View reviewed changes
content/en/docs/guides/performance.md Outdated Show resolved Hide resolved
content/en/docs/guides/performance.md Outdated Show resolved Hide resolved
@ananda1066 ananda1066 requested a review from markdroth July 1, 2021 17:55
ejona86
ejona86 approved these changes Jul 9, 2021
View reviewed changes
content/en/docs/guides/performance.md Outdated Show resolved Hide resolved
@ctiller ctiller merged commit 7f42f2a into grpc:main Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdroth markdroth markdroth approved these changes

@gnossen gnossen gnossen approved these changes

@ejona86 ejona86 ejona86 approved these changes

@vjpai vjpai vjpai approved these changes

@jtattermusch jtattermusch jtattermusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ananda1066 @srini100 @dfawley @gnossen @ejona86 @vjpai @jtattermusch @markdroth @ctiller