Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and test failing to bind a port on a server #13096

Closed
nathanielmanistaatgoogle opened this issue Oct 21, 2017 · 3 comments
Closed

Document and test failing to bind a port on a server #13096

nathanielmanistaatgoogle opened this issue Oct 21, 2017 · 3 comments
Assignees
Labels
area/documentation area/test disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! lang/Python

Comments

@nathanielmanistaatgoogle
Copy link
Member

nathanielmanistaatgoogle commented Oct 21, 2017

I believe that what will happen is that grpc.Server.add_insecure_port and grpc.Server.add_secure_port return 0 when they fail, but we don't currently document this and I don't recall our having a test for it.

@nathanielmanistaatgoogle
Copy link
Member Author

(gRPC Python should probably raise an exception when failing to bind a port?)

@mehrdada
Copy link
Member

I think that is the Python behavior indeed, which is curiously different from C++ ServerBuilder, where the actual binding gets deferred to server initialization, therefore, the integer output argument that gets filled only gets written to later in the server creation step and not immediately after AddPort.

@nathanielmanistaatgoogle nathanielmanistaatgoogle added the disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! label Mar 13, 2018
@nathanielmanistaatgoogle
Copy link
Member Author

Closing as a duplicate of issue 11394.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/documentation area/test disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! lang/Python
Projects
None yet
Development

No branches or pull requests

2 participants