gRPCTargets.cmake have invalid target properties

[hdnn]

What version of gRPC and what language are you using?

1.23.0

What operating system (Linux, Windows,...) and version?

Windows 10 Pro

What runtime / compiler are you using (e.g. python version or version of gcc)

MSBuilder

What did you do?

I compile gRPC, with generating gRPCTargets.cmake file(all dependences is "package")

What did you expect to see?

In gRPCTargets.cmake:
_set_target_properties(gRPC::grpc++ PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES "${IMPORT_PREFIX}/include"
INTERFACE_LINK_LIBRARIES "wsock32;ws2_32;OpenSSL::SSL;OpenSSL::Crypto;protobuf::libprotobuf;gRPC::grpc;gRPC::gpr"
)

What did you see instead?

In gRPCTargets.cmake:
_set_target_properties(gRPC::grpc++ PROPERTIES
INTERFACE_INCLUDE_DIRECTORIES "${IMPORT_PREFIX}/include"
INTERFACE_LINK_LIBRARIES "wsock32;ws2_32;OpenSSL::SSL;OpenSSL::Crypto;libprotoc;libprotobuf;gRPC::grpc;gRPC::gpr"
)
In this case "libprotoc;libprotobuf" evolves into libs names(without absolute path). As result it is impossible to build project that use gRPC, because 'libprotoc.lib' not found.

[jtattermusch]

CC @zackgalbreath

[jtattermusch]

When you say "As result it is impossible to build project that use gRPC, because 'libprotoc.lib' not found.", can you include the exact steps you've made an and the corresponding error log?
(we do have a distrib tests on for windows installation and it's passing, so you just might be doing something wrong).

[hdnn]

1. Create conan package by using this recipe: https://github.com/inexorgame/conan-grpc/tree/stable/1.23.0
2. in CMakeList.txt:
   set (LIB_DEPS protobuf::libprotobuf gRPC::grpc++ ) target_link_libraries(${PROJECT_NAME} PUBLIC ${LIB_DEPS})
3. Generate Visual Studio solution: >cmake %Self% -G %GeneratorName% -DFC_OUTPUT_DIR="%OutputDir%" -DCMAKE_CONFIGURATION_TYPES=%BuildType%
4. Open Solution, Project Settings - Linker - Input - Additional Dependencies:
   
   Green highlight - appeared from protobuf::libprotobuf, yellow highlight - appeared from gRPC::grpc++.
   But "yellow" libprotobufd.lib should have the same path that "green" libprotobufd.lib

[jtattermusch]

@hdnn can you reproduce using cmake only, without using conan? (we don't officially conan, so it's not clear to me if this is a problem in our cmake build or in the conan recipe).

[jtattermusch]

Seems similar to #12424?

[KyleFromKitware]

So far, I have not been able to get the Conan recipe to build on my Windows machine to reproduce this.

[jtattermusch]

Closing as "cannot reproduce".