Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package Grpc.HealthCheck Version 2.28.1 does not compile .NET 4.5 lib with #define GRPC_SUPPORT_WATCH #22736

Closed
andrekoehler opened this issue Apr 22, 2020 · 1 comment

Comments

@andrekoehler
Copy link

andrekoehler commented Apr 22, 2020

https://github.com/grpc/grpc/blob/v1.28.1/src/csharp/Grpc.HealthCheck/HealthServiceImpl.cs#L134

Decompiler output of

"C:\Users\andre\.nuget\packages\grpc.healthcheck\2.28.1\lib\net45\Grpc.HealthCheck.dll" shows that class "Grpc.HealthCheck.HealthServiceImpl" does not implement the Watch method, but
"C:\Users\andre\.nuget\packages\grpc.healthcheck\2.28.1\lib\net462\Grpc.HealthCheck.dll" does implement it!

I noticed this because I upgraded the Grpc.HealthCheck package in my .NET 4.5 hoping that I would get the implementation of the Watch method, but my client still returned error code UNIMPLEMENTED when calling the watch method.

@jtattermusch
Copy link
Contributor

jtattermusch commented May 13, 2020

The watch implementation is currently only supported for net462 and netstandard2.0.
https://github.com/grpc/grpc/pull/21120/files#diff-8a3c5313f31d458cd763e3da44471824R22

I'd recommend migrating to one the newer frameworks of them to benefit from all the new features. (an actual net45 is very very old).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants