Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not install channelz when gRPC_USE_PROTO_LITE #22826

Closed
avalon1610 opened this issue Apr 30, 2020 · 2 comments
Closed

Do not install channelz when gRPC_USE_PROTO_LITE #22826

avalon1610 opened this issue Apr 30, 2020 · 2 comments
Assignees
@veblush
Labels
disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! kind/bug lang/c++ priority/P3 untriaged

Comments

@avalon1610
Copy link

#21011 fixed issue that we should not compile channelz when use gRPC_USE_PROTO_LITE, but not for install.
when gRPC_INSTALL is ON, we got:
install TARGETS given target "grpcpp_channelz" which does not exist.

So we need add AND NOT gRPC_USE_PROTO_LITE to install part too.
@a11r a11r added disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! priority/P3 and removed priority/P2 labels May 12, 2020
@randrewy randrewy mentioned this issue Aug 17, 2020
Open
@tiolan
Copy link
Contributor

tiolan commented Mar 20, 2021

Any news on this?

@tiolan tiolan mentioned this issue Mar 20, 2021
Merged
@nicolasnoble nicolasnoble removed their assignment Jun 15, 2022
@veblush
Copy link
Contributor

veblush commented Sep 20, 2022

This was fixed by #25772

@veblush veblush closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veblush veblush

Labels
disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! kind/bug lang/c++ priority/P3 untriaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@avalon1610 @veblush @yashykt @nicolasnoble @a11r @donnadionne @markdroth @tiolan