Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake does not seem to install ssl option specific header files to set tls_min and tls_max for TLS version #28383

Closed
jairaju opened this issue Dec 17, 2021 · 1 comment

Comments

@jairaju
Copy link

jairaju commented Dec 17, 2021

What version of gRPC and what language are you using on what flavour?
grpc - 1.38.1(also tried with 1.42.0)
cmake version 3.20.5
gcc version 8.3.1
building on Linux/centos 7 for c++ libraries.

What did you do?
As per this proposal grpc/proposal#205
setting tls_min and tls_max for TLS version setting was introduced and I wanted to make use of those options to set TLS version
at client end

What did you expect to see?
I wanted to see grpc_tls_credentials_options.h to be installed in the path given in CMAKE_INSTALL_PREFIX

What did you see instead?
grpc_tls_credentials_options.h is not installed in the path given in CMAKE_INSTALL_PREFIX

Notes:
I can see that it builds alright but does not install the header files related to TLS version specifics namely grpc_tls_credentials_options.h and its dependent files such as src/core/lib/gprpp/ref_counted.h

cmake command is as follows:

cd cmake/build && cmake -DgRPC_INSTALL=ON -DCMAKE_INSTALL_PREFIX=$INSTALL_DIR -DgRPC_SSL_PROVIDER=package ../.. && make && make install)

I see that it builds fine - output in the manifest files
[ 75%] Building CXX object CMakeFiles/grpc.dir/src/core/lib/security/credentials/tls/grpc_tls_credentials_options.cc.o

I don't see Install lines for the same as we see for other security related stuffs like this
-- Installing: /home/build/grpc-1.38.1/include/grpcpp/security/credentials.h

Is it an issue with cmake build? or do I have to enable any flags/introduce any options to install those required files
Please note that I tried the latest 1.42.0 and find the same results

@stale
Copy link

stale bot commented Apr 16, 2022

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

@stale stale bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant