Made udp_server.c compile for iOS #3049
Conversation
| @@ -235,8 +235,10 @@ static int prepare_socket(int fd, const struct sockaddr *addr, int addr_len) { | |||
| rc = setsockopt(fd, IPPROTO_IP, IP_PKTINFO, &get_local_ip, | |||
| sizeof(get_local_ip)); | |||
| if (rc == 0 && addr->sa_family == AF_INET6) { | |||
| #if !TARGET_OS_IPHONE | |||
There was a problem hiding this comment.
port_platform.h checks it with #if TARGET_OS_IPHONE. I just negated that.
There was a problem hiding this comment.
Then you'd probably need at least a defined(APPLE) also, right?
On Mon, Aug 24, 2015 at 4:51 PM Michael Lumish notifications@github.com
wrote:
In src/core/iomgr/udp_server.c
#3049 (comment):@@ -235,8 +235,10 @@ static int prepare_socket(int fd, const struct sockaddr *addr, int addr_len) {
rc = setsockopt(fd, IPPROTO_IP, IP_PKTINFO, &get_local_ip,
sizeof(get_local_ip));
if (rc == 0 && addr->sa_family == AF_INET6) {
+#if !TARGET_OS_IPHONEport_platform.h checks it with #if TARGET_OS_IPHONE. I just negated that.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/pull/3049/files#r37818914.
There was a problem hiding this comment.
Undefined variables default to 0.
|
LGTM then. Waiting on Jenkins. |
Made udp_server.c compile for iOS
This is a temporary workaround for #3041.