Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock_stream.h is not externally visible when using Bazel #31296

Open
smolkaj opened this issue Oct 8, 2022 · 3 comments
Open

mock_stream.h is not externally visible when using Bazel #31296

smolkaj opened this issue Oct 8, 2022 · 3 comments

Comments

@smolkaj
Copy link

smolkaj commented Oct 8, 2022

What version of gRPC and what language are you using?

v1.49.1, C++

What operating system (Linux, Windows,...) and version?

Linux

What runtime / compiler are you using (e.g. python version or version of gcc)

LLVM / gcc with Bazel

What did you do?

Depend on the target @com_github_grpc_grpc//:grpc++_test in my BUILD.bazel file, see screenshot.

What did you expect to see?

For things to compile.

What did you see instead?

The following error message:

ERROR: /home/runner/work/pins-infra/pins-infra/p4_pdpi/BUILD.bazel:312:11: in cc_library rule //p4_pdpi:p4_runtime_session_mocking: target '@com_github_grpc_grpc//:grpc++_test' is not visible from target '//p4_pdpi:p4_runtime_session_mocking'. Check the visibility declaration of the former target if you think the dependency is legitimate

Anything else we should know about your project / environment?

I am a Google SWE working on a project that is used both internally and in open source.

This issue seems to be similar to #20208 and #20369.

Screenshot

image

@smolkaj
Copy link
Author

smolkaj commented Oct 8, 2022

@jonathan-dilorenzo for visibility

@yashykt
Copy link
Member

yashykt commented Jan 7, 2023

There seems to be some discussion around this on #26641

@rdesgroppes
Copy link

Is there a suggested way to overcome the visibility issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants