Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyi stubs are missing for protobuf types in grpcio-health-checking #32264

Closed
marcoferrer opened this issue Feb 1, 2023 · 4 comments · Fixed by #32268
Closed

Pyi stubs are missing for protobuf types in grpcio-health-checking #32264

marcoferrer opened this issue Feb 1, 2023 · 4 comments · Fixed by #32268

Comments

@marcoferrer
Copy link

What version of gRPC and what language are you using?

Python 3.11
grpcio-health-checking 1.51.1

What operating system (Linux, Windows,...) and version?

Mac

What runtime / compiler are you using (e.g. python version or version of gcc)

Python 3.11

What did you do?

Please provide either 1) A unit test for reproducing the bug or 2) Specific steps for us to follow to reproduce the bug. If there’s not enough information to debug the problem, gRPC team may close the issue at their discretion. You’re welcome to re-open the issue once you have a reproduction.

Protobuf types for health check API fail resolution due to pyi stubs missing in the wheel
image

What did you expect to see?

Protobuf types resolve correctly

What did you see instead?

My application still functions correctly, but ide intellisense is broken

Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).

See TROUBLESHOOTING.md for how to diagnose problems better.

Anything else we should know about your project / environment?

@gnossen
Copy link
Contributor

gnossen commented Feb 1, 2023

@XuanWang-Amos This will be resolved by #31769, right?

@XuanWang-Amos
Copy link
Contributor

XuanWang-Amos commented Feb 1, 2023

@XuanWang-Amos This will be resolved by #31769, right?

Not exactly, those are in *_pb2 files, I think we need help from protobuf team to add types to generated files.
It's not included in that PR but I published another one to fix it.

@marcoferrer
Copy link
Author

So I noticed that the pyi files are only generated when the pyi protoc generator is enabled. Is that already the case and the files were just not being included in the final artifact?

@gnossen
Copy link
Contributor

gnossen commented Feb 2, 2023

That was indeed the case. #32268 will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants