grpc doesn't build on centos5

[crowell]

grpc currently requires epoll_create1 http://linux.die.net/man/2/epoll_create1 which is called as epoll_create1(EPOLL_CLOEXEC), kernels before 2.6.32 don't have epoll_create1, and centos5 currently ships with 2.6.18.

  cc '-DCHROMIUM_REVISION=256281' '-D_GLIBCXX_USE_CXX11_ABI=0' '-DV8_DEPRECATION_WARNINGS' '-DBLINK_SCALE_FILTERS_AT_RECORD_T'-DUI_COMPOSITOR_IMAGE_TRANSPORT' '-DUSE_AURA=1' '-DUSE_CAIRO=1' '-DUSE_GLIB=1' '-DUSE_DEFAULT_RENDER_THEME=1' '-DUSE_LIBJPEG=1' '-DENABLE_WEBRTC=1' '-DENABLE_PEPPER_CDMS' '-DENABLE_CONFIGURATION_POLICY' '-DENABLE_INPUT_SPEECH' '-DENABLE_NOTIFICATIONUGIN_INSTALLATION=1' '-DENABLE_PLUGINS=1' '-DENABLE_SESSION_SERVICE=1' '-DENABLE_THEMES=1' '-DENABLE_AUTOFILL_DIALOG=1' '-DENG=1' '-DENABLE_SPELLCHECK=1' '-DENABLE_CAPTIVE_PORTAL_DETECTION=1' '-DENABLE_APP_LIST=1' '-DENABLE_SETTINGS_APP=1' '-DENABLE_c/src -Ithird_party/grpc/src/include -Ithird_party/chromium/src -Ithird_party/boringssl/src/include  -fstack-protector --paraity=hidden -pipe -fPIC -Wno-unused-local-typedefs -fexceptions -fasynchronous-unwind-tables -D_FORTIFY_SOURCE=2 -std=c99 -Wnoease/obj.target/grpc_core/third_party/grpc/src/src/core/iomgr/pollset_multipoller_with_epoll.o.d.raw  -c -o out/Release/obj.tmultipoller_with_epoll.c
third_party/grpc/src/src/core/iomgr/pollset_multipoller_with_epoll.c: In function ‘epoll_become_multipoller’:
third_party/grpc/src/src/core/iomgr/pollset_multipoller_with_epoll.c:294:3: warning: implicit declaration of function ‘epoll_
   h->epoll_fd = epoll_create1(EPOLL_CLOEXEC);
   ^
third_party/grpc/src/src/core/iomgr/pollset_multipoller_with_epoll.c:294:31: error: ‘EPOLL_CLOEXEC’ undeclared (first use in 
   h->epoll_fd = epoll_create1(EPOLL_CLOEXEC);
                               ^
third_party/grpc/src/src/core/iomgr/pollset_multipoller_with_epoll.c:294:31: note: each undeclared identifier is reported onl
make: *** [out/Release/obj.target/grpc_core/third_party/grpc/src/src/core/iomgr/pollset_multipoller_with_epoll.o] Error 1

[soltanmm]

This was something we hit when trying to support Python's manylinux1 ABI tag (which targets CentOS 5). While unobvious, specifying -DGPR_MANYLINUX1 should set up the right implementation for that target.

Obviously not claiming that this is the way things should be handled for CentOS 5, but it's there.

[crowell]

--snip-- log pasted here was due to a mistake in my gypfile.

[sreecha]

Is this still an issue? - as far as I remember, this should have been fixed..

[soltanmm-google]

It should be addressable from the port_platform.h defines AFAIK (and e.g. via specifying GPR_MANYLINUX).