Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable core build against musl #8899

Closed
soltanmm-google opened this issue Nov 29, 2016 · 8 comments
Closed

Enable core build against musl #8899

soltanmm-google opened this issue Nov 29, 2016 · 8 comments
Assignees
Labels
area/build area/core disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! kind/enhancement
Milestone

Comments

@soltanmm-google
Copy link
Contributor

cf. Alpine Linux

Just coalescing the issues.

#8658
#6850

@soltanmm-google soltanmm-google added area/core disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! labels Nov 29, 2016
@soltanmm-google soltanmm-google added this to the 1.1 milestone Nov 29, 2016
@soltanmm-google soltanmm-google changed the title Enable core to build against musl Enable core build against musl Nov 29, 2016
@eljefedelrodeodeljefe
Copy link

is there an intention to move forward on this?

@MaxDesiatov
Copy link

any updates on this issue?

@ernie
Copy link
Contributor

ernie commented Mar 15, 2017

I've also been struggling to find a suitable solution for this -- grpc is a dependency of the google-cloud-pubsub Ruby gem, and so I'd very much like to be able to build this under Alpine -- we're building from source for all gems because of issues with the prebuilt version of google-protobuf on Alpine, and to hopefully increase the likelihood that we see potential issues at build time vs runtime.

I'd prefer to avoid adding additional third-party packages via wget (as with alpine-pkg-glibc) if at all possible.

@andreacalia
Copy link

Hi, even if this feature is under review, I'd like to report that it doesn't work on Alpine:3.5 (docker)

docker run -it alpine:latest sh
/ # apk update
/ # apk add python3-dev build-base
/ # python3 -m pip install grpcio-tools

Command "/usr/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-build-mf96m1gz/grpcio-tools/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /tmp/pip-tij0ogir-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-mf96m1gz/grpcio-tools/

@hsaliak
Copy link
Contributor

hsaliak commented May 5, 2017

@kpayson64 could you please investigate..

@andreacalia could you please provide the output of pip list | grep grpc

@kpayson64
Copy link
Contributor

@hsaliak @andreacalia
grpcio-tools 1.3.0 will not run on Alpine linux because it depends on protobuf 3.2.x, and protobuf did not support alpine linux until 3.3.0 (which was not available in time for the 1.3.0 release).

In our 1.4.0 release, we will upgrade our protobuf dependency, #10995. The grpcio package should build under alpine linux.

@hsaliak
Copy link
Contributor

hsaliak commented May 5, 2017

@kpayson64 got it, thanks! Since this issue tracks core build against musl, the issue can be closed.
@andreacalia wdyt?

@andreacalia
Copy link

@hsaliak @kpayson64 thanks!
Indeed python lib grpcio is correctly built in alpine. So we'll wait for the 1.4.0 release :)

@dgquintas dgquintas removed this from In Review in gRPC 1.5 [2017-Jul-06] May 18, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Oct 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/build area/core disposition/help wanted Maintainers do not have enough resources to allocate to this at the moment. Help is appreciated! kind/enhancement
Projects
None yet
Development

No branches or pull requests

8 participants