Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design & implement asynchronous completion queue based alarms #1949

Closed
ctiller opened this issue Jun 5, 2015 · 4 comments
Closed

Design & implement asynchronous completion queue based alarms #1949

ctiller opened this issue Jun 5, 2015 · 4 comments
Assignees
Milestone

Comments

@ctiller
Copy link
Member

ctiller commented Jun 5, 2015

#1948 exposed a weakness in our Async API when doing timing based work - it gets incredibly difficult to express.

Consider something like:

namespace grpc {
class Alarm {
 public:
  // emits a completion to cq with tag 'tag' on completion
  void Start(CompletionQueue* cq, void* tag, some_time_type deadline);
  void Cancel();
};
}

This would need a C surface API implementation, and could be implemented in terms of the existing iomgr alarm list code.

@ctiller ctiller added this to the Beta milestone Jun 5, 2015
@ctiller ctiller self-assigned this Jun 5, 2015
@ctiller
Copy link
Member Author

ctiller commented Jul 17, 2015

This is an additive API can can wait until post beta.

@ctiller ctiller closed this as completed Jul 17, 2015
@ctiller ctiller reopened this Jul 17, 2015
@ctiller ctiller removed this from the Beta milestone Jul 17, 2015
@vjpai
Copy link
Member

vjpai commented Jul 17, 2015

Agreed that it can wait until post beta.

On Fri, Jul 17, 2015 at 3:25 PM Craig Tiller notifications@github.com
wrote:

Reopened #1949 #1949.


Reply to this email directly or view it on GitHub
#1949 (comment).

@ctiller ctiller modified the milestone: GA Jul 19, 2015
@ctiller ctiller assigned dgquintas and unassigned ctiller Nov 5, 2015
@ctiller
Copy link
Member Author

ctiller commented Nov 5, 2015

Reassigning so dgq gets to close it.

@dgquintas
Copy link
Contributor

Done in #3618

@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants