Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L60: Remove custom allocation function overrides from core surface API #162

Merged
merged 4 commits into from
Oct 31, 2019

Conversation

veblush
Copy link
Contributor

@veblush veblush commented Oct 8, 2019

I'll add a link to the discussion once initial review is done.

@veblush veblush requested a review from markdroth October 8, 2019 23:09
@markdroth markdroth changed the title L60: Remove grpc_use_signal from core surface API L60: Remove custom allocation function overrides from core surface API Oct 9, 2019
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall! Just a couple of minor comments.

L60-core-remove-custom-allocator.md Outdated Show resolved Hide resolved
L60-core-remove-custom-allocator.md Outdated Show resolved Hide resolved
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@veblush veblush merged commit 81002ef into grpc:master Oct 31, 2019
@veblush veblush deleted the L60 branch October 31, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants