A52: gRPC xDS Custom Load Balancer Configuration #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temawi
added a commit
to temawi/grpc-proto
that referenced
this pull request
Apr 25, 2022
This change is explained in detail in the custom LB config proposal: grpc/proposal#298
markdroth
reviewed
Apr 25, 2022
temawi
added a commit
to grpc/grpc-java
that referenced
this pull request
Apr 28, 2022
This LB is the parent for weighted_target and will configure it based on the child policy it gets in its configuration and locality weights that come in a ResolvedAddresses attribute. Described in [A52: gRPC xDS Custom Load Balancer Configuration](grpc/proposal#298)
temawi
added a commit
to grpc/grpc-proto
that referenced
this pull request
Apr 29, 2022
This change is explained in detail in the custom LB config proposal: grpc/proposal#298
ejona86
reviewed
May 2, 2022
A52-xds-custom-lb-policies.md
Outdated
|
|
||
| The load balancer config portion of the CDS update struct will change to take the following form: | ||
|
|
||
| ```json |
There was a problem hiding this comment.
This isn't actually JSON though, right? This is for the internal struct. Seems we should use a programming language syntax.
There was a problem hiding this comment.
I was just going for some language neutral syntax. Switched to C.
| ```textproto | ||
| { // Cluster | ||
| load_balancing_policy: { | ||
| policies: [ |
There was a problem hiding this comment.
[ for messages doesn't look like textproto format. The syntax highlighter is also complaining about this.
There was a problem hiding this comment.
Textproto does actually support [...] for repeated fields these days.
There was a problem hiding this comment.
@markdroth, it supports [...] it for repeated messages? I've only seen it for repeated scalars. (In text_format.h, I think that is SetUseShortRepeatedPrimitives(true).)
There was a problem hiding this comment.
Seems to only be mentioned in Google internal documentation, but go/textformat-spec does include [...] support for repeated messages.
yashykt
reviewed
May 3, 2022
yashykt
reviewed
May 3, 2022
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
May 3, 2022
Renames the LegacyLoadBalancerConfigFactory to just LoadBalancerConfigFactory and gives it responsibility for both the legacy and the new LB config mechanism. The new configuration mechanism is exaplained in gRFC A52: grpc/proposal#298
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
May 3, 2022
Renames the LegacyLoadBalancerConfigFactory to just LoadBalancerConfigFactory and gives it responsibility for both the legacy and the new LB config mechanism. The new configuration mechanism is exaplained in gRFC A52: grpc/proposal#298
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
May 3, 2022
Renames the LegacyLoadBalancerConfigFactory to just LoadBalancerConfigFactory and gives it responsibility for both the legacy and the new LB config mechanism. The new configuration mechanism is exaplained in gRFC A52: grpc/proposal#298
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
May 3, 2022
Renames the LegacyLoadBalancerConfigFactory to just LoadBalancerConfigFactory and gives it responsibility for both the legacy and the new LB config mechanism. The new configuration mechanism is exaplained in gRFC A52: grpc/proposal#298
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
May 4, 2022
Renames the LegacyLoadBalancerConfigFactory to just LoadBalancerConfigFactory and gives it responsibility for both the legacy and the new LB config mechanism. The new configuration mechanism is explained in gRFC A52: grpc/proposal#298
yashykt
reviewed
May 4, 2022
yashykt
reviewed
May 4, 2022
ejona86
approved these changes
May 4, 2022
yashykt
reviewed
May 5, 2022
A52-xds-custom-lb-policies.md
Outdated
| { | ||
| ... | ||
|
|
||
| "lb_policy_config": <array of LoadBalancingConfig JSON objects> |
There was a problem hiding this comment.
Can you add a comment as to why this is an array? (since by the point this JSON will be created, we would have only a single LoadBalancingConfig object)
There was a problem hiding this comment.
It was just for compatibility with existing C config parsing libraries that expect to receive an array.
temawi
added a commit
to grpc/grpc-java
that referenced
this pull request
May 6, 2022
…#9141) Instead of providing round robin or least request configurations directly, ClientXdsClient now wraps them in a WRR locality config. ClusterResolverLoadBalancer passes this configuration directly to PriorityLoadBalancer to use as the endpoint LB policy it provides to ClusterImplLoadBalancer. A new ResolvedAddresses attribute is also set that has all the locality weights. This is needed by WrrLocalityLoadBalancer when it configures WeightedTargetLoadBalancer. Renames the LegacyLoadBalancerConfigFactory to just LoadBalancerConfigFactory and gives it responsibility for both the legacy and the new LB config mechanism. The new configuration mechanism is explained in gRFC A52: grpc/proposal#298
yashykt
approved these changes
May 6, 2022
markdroth
approved these changes
May 6, 2022
dfawley
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new proposal for refactoring how xDS LB policy configuration is processed and how custom LB policies can be configured.