Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A64: xDS LRS Custom Metrics Support #368

Merged
merged 4 commits into from
May 27, 2023
Merged

A64: xDS LRS Custom Metrics Support #368

merged 4 commits into from
May 27, 2023

Conversation

yousukseung
Copy link
Contributor

No description provided.

@yousukseung yousukseung marked this pull request as ready for review May 10, 2023 13:18
@markdroth markdroth changed the title A59: xDS LRS Named Metrics Support A64: xDS LRS Named Metrics Support May 10, 2023
markdroth
markdroth reviewed May 10, 2023
View reviewed changes
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up!

Please let me know if you have any questions.

A59-lrs-named-metrics.md Outdated Show resolved Hide resolved
A59-lrs-named-metrics.md Outdated Show resolved Hide resolved
A59-lrs-named-metrics.md Outdated Show resolved Hide resolved
A59-lrs-named-metrics.md Outdated Show resolved Hide resolved
A59-lrs-named-metrics.md Outdated Show resolved Hide resolved
A59-lrs-named-metrics.md Outdated Show resolved Hide resolved
A59-lrs-named-metrics.md Outdated Show resolved Hide resolved
A59-lrs-named-metrics.md Outdated Show resolved Hide resolved
markdroth
markdroth reviewed May 11, 2023
View reviewed changes
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall! Remaining comments are mostly cosmetic.

Please let me know if you have any questions. Thanks!

A64-lrs-custom-metrics.md Outdated
* Status: Ready for Implementation
* Implemented in: C-core
* Last updated: 2023-05-10
* Discussion at: TBA
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go ahead and create the mailing list thread and then add a link here. This is what starts the 2-week timer before we can merge the gRFC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait till 5/26.

A64-lrs-custom-metrics.md Outdated Show resolved Hide resolved
A64-lrs-custom-metrics.md Outdated Show resolved Hide resolved
A64-lrs-custom-metrics.md Outdated Show resolved Hide resolved
A64-lrs-custom-metrics.md Outdated Show resolved Hide resolved
@yousukseung yousukseung changed the title A64: xDS LRS Named Metrics Support A64: xDS LRS Custom Metrics Support May 12, 2023
markdroth
markdroth reviewed May 12, 2023
View reviewed changes
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Just a couple of minor nits remaining, and we need to wait 2 weeks before merging.

A64-lrs-custom-metrics.md Outdated Show resolved Hide resolved
A64-lrs-custom-metrics.md Outdated Show resolved Hide resolved
ejona86
ejona86 approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming that lack of environment variable protection was on purpose.

@yousukseung
Copy link
Contributor Author

LGTM, assuming that lack of environment variable protection was on purpose.

Yes, there is none that I am aware of and I think we won't protect this when adding in Java/Go later.

markdroth
markdroth approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be merged now.

@yousukseung yousukseung merged commit 3d91f90 into grpc:master May 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@markdroth markdroth markdroth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yousukseung @ejona86 @markdroth