L105: Python Add New Error Types #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
approved these changes
Aug 31, 2023
| ## Rationale | ||
|
|
||
| The Async API [has similar errors](https://github.com/grpc/grpc/blob/v1.57.x/src/python/grpcio/grpc/aio/__init__.py#L23,L24). We're refactoring code so those errors will also be used in Sync API. Adding them to the Sync API will help us keep the two stacks in sync and allow users of the Sync implementation to catch and handle aborts. | ||
|
|
There was a problem hiding this comment.
We probably want to mention that adding this will allow users to type:
try:
do_grpc_stuff()
except grpc.BaseError as e:
# handle errorand be confident that they're catching all gRPC exceptions.
There was a problem hiding this comment.
We also have RpcError exposed to user, I think we should mention their differences, when should user expect RpcError?
There was a problem hiding this comment.
If RpcError is not currently a subclass of BaseError, I think we should make it a subclass of BaseError. Ditto for all other exception types. The ultimate goal is to enable the snippet above.
There was a problem hiding this comment.
Make sense, I'll change RpcError to be a subclass of BaseError and add it to this gRFC.
XuanWang-Amos
added a commit
to grpc/grpc
that referenced
this pull request
Sep 27, 2023
Fix: #33890 In case of abort, currently we don't log anything, this change added an `AbortError` as the default error for abort, if any other error happened, we'll log the error so user will be aware of the other error. Related gRFC: grpc/proposal#388 ### Testing * Tested locally, after this change, any non-AbortError will be logged, sample log: ``` ERROR:grpc._server:Exception happened while abort: Other exception happened! Traceback (most recent call last): File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/9/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_abort_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio/grpc/_server.py", line 553, in _call_behavior response_or_iterator = behavior(argument, context) File "/usr/local/google/home/xuanwn/.cache/bazel/_bazel_xuanwn/da3828576aa39e99a5c826cc2e2e22fb/sandbox/linux-sandbox/9/execroot/com_github_grpc_grpc/bazel-out/k8-fastbuild/bin/src/python/grpcio_tests/tests/unit/_abort_test.native.runfiles/com_github_grpc_grpc/src/python/grpcio_tests/tests/unit/_abort_test.py", line 95, in abort_with_status_unary_unary_raise_additional_exception raise Exception("Other exception happened!") Exception: Other exception happened! ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new errors in grpc public API.
Discussion thread: https://groups.google.com/g/grpc-io/c/pG34X9nAa3c