New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L13: gRPC Python Client and Server Interceptors #39

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@mehrdada
Member

mehrdada commented Oct 2, 2017

@googlebot googlebot added the cla: yes label Oct 2, 2017

@hsaliak

This comment has been minimized.

Show comment
Hide comment
@hsaliak

hsaliak Feb 2, 2018

Member

@nathanielmanistaatgoogle please approve so that this proposal can be merged in a timely manner.

Member

hsaliak commented Feb 2, 2018

@nathanielmanistaatgoogle please approve so that this proposal can be merged in a timely manner.

@mehrdada

This comment has been minimized.

Show comment
Hide comment
@mehrdada

mehrdada Feb 2, 2018

Member

I need to make modifications to it. The API has somewhat changed. Please hold off on reviewing it. I have not forgotten.

Member

mehrdada commented Feb 2, 2018

I need to make modifications to it. The API has somewhat changed. Please hold off on reviewing it. I have not forgotten.

@naggie

This comment has been minimized.

Show comment
Hide comment
@naggie

naggie Feb 2, 2018

After following about 6 links in various PRs and issues around the same change, I'm confused about the status of this interceptor feature -- is it already in 1.8.x? -- I see it in the release notes for v1.8.0

Thanks for the work on this feature, it will allow me to remove considerable boilerplate.

naggie commented Feb 2, 2018

After following about 6 links in various PRs and issues around the same change, I'm confused about the status of this interceptor feature -- is it already in 1.8.x? -- I see it in the release notes for v1.8.0

Thanks for the work on this feature, it will allow me to remove considerable boilerplate.

@mehrdada

This comment has been minimized.

Show comment
Hide comment
@mehrdada

mehrdada Feb 2, 2018

Member

@naggie Yes, we pursued this proposal and captured some user feedback and an experimental version (which will very likely become final after marking this proposal as approved) is merged already and is ready to use. I still need to update this proposal to incorporate the feedback and update it to match the version that we shipped since 1.8.

Member

mehrdada commented Feb 2, 2018

@naggie Yes, we pursued this proposal and captured some user feedback and an experimental version (which will very likely become final after marking this proposal as approved) is merged already and is ready to use. I still need to update this proposal to incorporate the feedback and update it to match the version that we shipped since 1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment