Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L108: Node.js Reflection Server Library #397

Merged
merged 7 commits into from Nov 8, 2023

Conversation

jtimmons
Copy link
Contributor

adding proposal as discussed in grpc/grpc-node#79

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 10, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@murgatroid99 murgatroid99 self-requested a review October 10, 2023 22:35
@murgatroid99 murgatroid99 changed the title L107: first draft of node gRPC reflection library proposal L107: Node.js Reflection Server Library Oct 10, 2023
@murgatroid99
Copy link
Member

I took the liberty of updating the PR title. The proposal itself is for the "Node.js Reflection Server Library", and the status can be managed within the text of the proposal document. Please list me as the approver, create a discussion thread as described in the README's process section, and update the status in the document to "In Review".

In addition, L107 is already reserved for #395, so please update the PR title and text to L108.

@jtimmons jtimmons changed the title L107: Node.js Reflection Server Library L108: Node.js Reflection Server Library Oct 10, 2023
Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed in grpc/grpc-node#79, it should be possible for the Server class to expose all of the necessary information to support reflection. The reflection library should have an API to take advantage of that by making it as simple as possible to add reflection, e.g. it could export a top-level function enableReflection(server). This is also important because a server can have services based on proto files that the user does not have direct access to: in grpc-js, the addAdminServicesToServer adds the channelz service, and also the CSDS service if using xDS.

L108-node-grpc-reflection-library.md Outdated Show resolved Hide resolved
L108-node-grpc-reflection-library.md Outdated Show resolved Hide resolved
L108-node-grpc-reflection-library.md Outdated Show resolved Hide resolved
L108-node-grpc-reflection-library.md Outdated Show resolved Hide resolved
@murgatroid99 murgatroid99 merged commit 9c41426 into grpc:master Nov 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants