Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTBFS with Pd64>=0.55 #57

Closed
umlaeute opened this issue Jun 17, 2024 · 3 comments
Closed

FTBFS with Pd64>=0.55 #57

umlaeute opened this issue Jun 17, 2024 · 3 comments

Comments

@umlaeute
Copy link
Contributor

the problem is apparently, that the defsig signal holder is float, but should be t_float:

float defsig;

Pd>=0.55 now uses static assertions to catch wrongly typed signal holders, hence the problem starts to show now.

@grrrr
Copy link
Owner

grrrr commented Jun 17, 2024

really t_float? Or rather t_sample? Both are PD_FLOATTYPE, but it seems t_sample should be for signals.

@grrrr
Copy link
Owner

grrrr commented Jun 17, 2024

Ah, i see, the assertion in Pd is for sizeof(t_float)... it's a simple fix.

@grrrr
Copy link
Owner

grrrr commented Jun 17, 2024

fixed by commit f3b6328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants