Fix possible buffer overrun on Audio signal channel string #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrung
force-pushed
the
fix-Wformat-overflow
branch
from
5fc4bf2
to
eb052b6
Compare
GCC warns about a possible buffer overrun:
```
source/groove.cpp: In constructor ‘xgroove::xgroove(int, const t_atom*)’:
source/groove.cpp:243:56: warning: ‘%i’ directive writing between 1 and 10 bytes into a region of size 9 [-Wformat-overflow=]
243 | STD::sprintf(tmp,"Audio signal channel %i",ci+1);
| ^~
source/groove.cpp:243:34: note: directive argument in the range [1, 2147483647]
243 | STD::sprintf(tmp,"Audio signal channel %i",ci+1);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
```
Commit 770fd99 fixed one instance of
the code in `play.cpp` but did not fix `grove.cpp`.
Increase the buffer by the needed byte and use the same value for the
duplicate code.
Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
bdrung
force-pushed
the
fix-Wformat-overflow
branch
from
eb052b6
to
f2b6d90
Compare
|
Thank you, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC warns about a possible buffer overrun:
Commit 770fd99 fixed one instance of the code in
play.cppbut did not fixgrove.cpp.Increase the buffer by the needed byte and use the same value for the duplicate code.