Fix lazy loading #1
Conversation
Some one might want to use `darkman-set` and `darkman-get-theme` directly and the modules should be loaded lazily
|
I've re-based the changes on top of |
|
Could you please take into consideration my comments on the change you introduced in the README? |
|
Sometimes GitHub has issues notifying contributors of an active review, are you able to see the review comments? |
Sure. I've split |
|
Thanks a lot! |
README.org
Outdated
| @@ -16,6 +16,12 @@ Add the package to the =load-path= and then require it like so: | |||
| (add-to-list 'load-path "darkman") | |||
| (require 'darkman) | |||
| #+end_src | |||
| ** For [[https://github.com/radian-software/straight.el][straight.el]] users: | |||
There was a problem hiding this comment.
I would personally prefer it if this were not a heading, just a normal sentence.
There was a problem hiding this comment.
I take back what I said, I'd much rather keep the installation section as short as possible, and for two reasons:
- There's a bazillion ways to install something in Emacs, there's too much boilerplate involved.
straight.elusers can automatically determine what to put in their configurations to use this package thestraight.el-way -- and same goes foruse-package, however I would make an exception to this once29.0.5is released, at which point the package is built-in and therefore I'd be much more inclined to include the boilerplate associated with it.
|
Thank you for your patience and your contribution :) |
Fix lazy loading of the darkman.el package.
Actively loading a package
(load "darkman.el")works fine, but if you have a lot of packages, loading all of them takes a lot of time. It is more effecent to have the package loaded lazily on demand.