This repository has been archived by the owner on Jul 5, 2023. It is now read-only.
Handle dbus events instead of signals #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emacs gets several signals related with different events of dbus which makes it appear that it receives the same signals multiple times as commented in Because we don't need to be listening all kinds of signals, we could just listen for events over a dbus name by using `dbus-register-monitor`. Along with this, the commit includes: * Replace `darkman--mode-changed-signal-handler` with `darkman--call-event-handler` to be a real handler of all method_call events from darkman dbus. * Create `darkman-load-theme-mode` function that will be called every time `Mode` property in `nl.whynothugo.darkman` interface is called. * Add Package-Requires Emacs 28.1 to fix warnings from package-lint * Set related issue tasks as DONE * Fix grtcdr#10 as commented @grtcdr in #issuecomment-1447145236
|
Feel free to suggest or ask anything to improve the PR @grtcdr 👍 |
grtcdr
reviewed
Feb 28, 2023
Too early and few cases to do so.
grtcdr
approved these changes
Feb 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emacs gets several signals related with different events of dbus which makes it appear that it receives the same signals multiple times as commented in Because we don't need to be listening all kinds of signals, we could just listen for events over a dbus name by using
dbus-register-monitor.Along with this, the commit includes:
darkman--mode-changed-signal-handlerwithdarkman--call-event-handlerto be a real handler of all method_call events from darkman dbus.darkman-load-theme-modefunction that will be called every timeModeproperty innl.whynothugo.darkmaninterface is called.