Skip to content

Commit

Permalink
Fixed marklogic-community#414: ENV vars override loaded prop values
Browse files Browse the repository at this point in the history
  • Loading branch information
grtjn committed Jul 8, 2015
1 parent 72a6964 commit 8525dc9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion deploy/lib/server_config.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1923,7 +1923,7 @@ def ServerConfig.load_properties(properties_filename, prefix = "")
if i
key = prefix + line[0..i - 1].strip
value = line[i + 1..-1].strip
properties[key] = value
properties[key] = ENV[key.sub("ml.", "ml_")] || value
end
end
end
Expand Down

3 comments on commit 8525dc9

@rlouapre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should all dots be replaced by _?

See http://stackoverflow.com/a/2821183

@grtjn
Copy link
Owner Author

@grtjn grtjn commented on 8525dc9 Sep 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes makes sense. Will require a new PR though..

@rlouapre
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- should also be replaced by _.

Please sign in to comment.