Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Module system compatibility #505

Closed
driesdeproost opened this issue Nov 28, 2023 · 3 comments · Fixed by #533
Closed

Java Module system compatibility #505

driesdeproost opened this issue Nov 28, 2023 · 3 comments · Fixed by #533

Comments

@driesdeproost
Copy link

Hi

Thanks for this project. We think it looks promising and would like to try it out in one of our projects.
However, we use the Java module system and we are not able to require transactionoutbox-core and transactionoutbox-spring at the same time.

screenshot

All subproject artifacts contain modules that export to the same package com.gruelbox.transactionoutbox.
I suppose this is default behaviour when the same package structure is used throughout the project.

Split packages are not allowed by the Java module system.
Would it be possible to alter the package structure in every subproject so that they are more specific?

@driesdeproost driesdeproost changed the title Automatic module name Java Module system compatibility Nov 28, 2023
@badgerwithagun
Copy link
Member

Hi @driesdeproost. I would like to make this change but it'd be a big compatibility break.

I started doing it as part of #40 and have never quite got it to a point where it's ready to be released. Every now and then I make another big push to get it finished - maybe one for the holiday season!

@badgerwithagun
Copy link
Member

@driesdeproost it will take a few versions before I can remove the duplicated/deprecated classes by merging #533, but when I do, this should be fixed

@driesdeproost
Copy link
Author

Awesome, thanks a lot!

We worked around it for now by just copying some implementation into our project and that worked perfectly so far!
Looking forward to being able to remove that duplicated code some day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants