Graphics are broken links

[stealthrabbi]

Broken link for image, at least in Chrome. TeamCity 10.0.3.

[stealthrabbi]

The actual browser notification has the text, but no icon.

[stealthrabbi]

from browser inspector:

[grundic]

@stealthrabbi, thank you for your bug report!
Will check this issue, should be some trivial error with resources.

[grundic]

Hm, strange. Could not reproduce your issue. Can you give some more information about your environment? What operating system do you use?

Can you take a look at <TEAMCITY_INSTALLATION>/webapps/ROOT/plugins/teamcity-browser-notify. It should look something like this:

TeamCity-10.0.3/webapps/ROOT/plugins/teamcity-browser-notify
└── com
    └── github
        └── grundic
            └── browser
                └── notificator
                    ├── img
                    │   ├── permission_denied.png
                    │   ├── permission_granted.png
                    │   └── teamcity_logo.png
                    ├── js
                    │   ├── listener.js
                    │   ├── notify.js
                    │   └── settings.js
                    └── jsp
                        ├── empty.jsp
                        └── settings.jsp

8 directories, 8 files

[stealthrabbi]

My directory looks like that, although my teamcity is not installed in webapps/ROOT, but instead webapps/teamcity.

[stealthrabbi]

I'm on Windows, FWIW. Is there maybe an issue with permissions on the image files?

[grundic]

Well, webapps/teamcity looks weird: just installed Teamcity on Windows through the installer and here is the installation path: C:\TeamCity\webapps\ROOT. How did you installed your version of TeamCity?

[stealthrabbi]

I just moved it from ROOT to teamcity so teamcity would be in the URL. I think I installed via the MSI before, and update by giving downloading new WAR files.

Everything else works fine with teamcity.

[grundic]

I see, you've done something like this: http://stackoverflow.com/questions/6071426/teamcity-behind-nginx-proxy.

Okay, now I understand the problem. Would try to find a solution for that.

[stealthrabbi]

no, i'm not behind a proxy. I just wanted to change the URL for the teamcity install.

Is there something in your plugin that expects the webapp to be in root?

[grundic]

There is a path to the icons, which doesn't expect custom path of Teamcity...
Have to change it here.

[grundic]

@stealthrabbi, fixed that in 1.0.1, please have a look.
Thank you for your issue :)

[stealthrabbi]

Alright, so i've never updated a plugin before. Do i just delete the old zip from the plugins dir and replace with the new one?

[grundic]

Yep, that should be enough.

[stealthrabbi]

tested out the new version. works good. Thanks!

[grundic]

Awesome!
Thank you as well for finding this issue.