Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lld-disks.py #13

Closed
wants to merge 1 commit into from
Closed

Update lld-disks.py #13

wants to merge 1 commit into from

Conversation

strobil
Copy link

@strobil strobil commented Aug 3, 2016

  • Ignore dm-crypt devices
  • Ignore block device partitions using regular expression (probably not a best method)

Ignore block device partitions using regular expression (probably not a best method)
@grundic
Copy link
Owner

grundic commented Sep 7, 2016

@strobil, hey!
Sorry for long absence..

Can you explain what is second if for? You would like to filter everything that only has letters in name? Can you please provide an examples that are filtered?

@strobil
Copy link
Author

strobil commented Sep 7, 2016

@grundic
Second "if" will filter device partitions.
Instead of creating sda1,sda2,sda3.. etc - it will create only sda monitoring item.

Now i think that is not a good idea, because in my case all disks have one partition, but
in other cases, it might be usefull, because of different device partitions can me mounted on different mount points.

So, i think it would be better if i remain only "dm" in "skippable". What do you think?

@grundic
Copy link
Owner

grundic commented Sep 8, 2016

DM are virtual entities, that could unite other disks in software RAIDs or LVM2, so I would say that we should not skip it.

Furtheremore, there are filters for lld rules as described here, so anyone can apply them during runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants